Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add mobx vs inherited model #966

Merged
merged 1 commit into from
Dec 7, 2023
Merged

docs: add mobx vs inherited model #966

merged 1 commit into from
Dec 7, 2023

Conversation

amondnet
Copy link
Collaborator

@amondnet amondnet commented Dec 7, 2023 •
edited
Loading

Describe the changes proposed in this Pull Request.

@amondnet you should write a blog post about this on the MobX Website ... this kind of information is useful for general audience as well. Just a recommendation :-)

Originally posted by @pavanpodila in #948 (reply in thread)

Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melos run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

@netlify Netlify
Copy link

netlify bot commented Dec 7, 2023

👷 Deploy request for mobx pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 2953bc6

@amondnet amondnet self-assigned this Dec 7, 2023
@amondnet amondnet added the docs Add documentation around this topic label Dec 7, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited
Loading

Codecov Report

Merging #966 (2953bc6) into main (1388bbd) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #966   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files          57       57           
  Lines        2005     2005           
=======================================
  Hits         1985     1985           
  Misses         20       20
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.56% <ø> (ø)
mobx_codegen 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1388bbd...2953bc6. Read the comment docs.

@amondnet amondnet requested a review from pavanpodila December 7, 2023 02:26
@pavanpodila pavanpodila merged commit 52515a1 into mobxjs:main Dec 7, 2023
8 checks passed
@amondnet amondnet deleted the docs-mobx-vs-inherited-model branch December 13, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavanpodila pavanpodila pavanpodila approved these changes

Assignees

@amondnet amondnet

Labels
docs Add documentation around this topic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amondnet @pavanpodila